Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camera controls updates #7141

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Camera controls updates #7141

merged 5 commits into from
Nov 27, 2024

Conversation

kpal81xd
Copy link
Contributor

  • Removed creation of new entity
  • Moves script into /scripts/esm

@kpal81xd kpal81xd self-assigned this Nov 26, 2024
@kpal81xd kpal81xd requested review from a team and willeastcott November 26, 2024 14:17
slimbuck
slimbuck approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please get another approval regarding script location and naming.

@kpal81xd
Copy link
Contributor Author

Approving, but please get another approval regarding script location and naming.

Spoke with Will already about it but need to reorganise all the scripts to property split legacy and ESM into separate folders

@kpal81xd kpal81xd merged commit d68f412 into main Nov 27, 2024
8 checks passed
@kpal81xd kpal81xd deleted the camera-controls branch November 27, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@willeastcott willeastcott willeastcott approved these changes

Assignees

@kpal81xd kpal81xd

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpal81xd @willeastcott @slimbuck