Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support compressed spherical harmonics #7143

Merged
merged 10 commits into from
Nov 27, 2024
Merged

Support compressed spherical harmonics #7143

merged 10 commits into from
Nov 27, 2024

Conversation

slimbuck
Copy link
Member

(Replaces #7127).

This PR:

  • supports loading, decompressing and directly rendering compressed spherical harmonic data
  • 1, 2 or 3 bands of coefficients are supported which take 9, 24 and 45 bytes per splat, respectively
  • coefficients are quantised to 8 bits
  • data must be padded for upload to GPU

@slimbuck slimbuck added area: graphics Graphics related issue enhancement labels Nov 26, 2024
@slimbuck slimbuck requested a review from a team November 26, 2024 19:28
@slimbuck slimbuck self-assigned this Nov 26, 2024
@slimbuck slimbuck merged commit f0f7add into playcanvas:main Nov 27, 2024
8 checks passed
@slimbuck slimbuck deleted the sh-dev-2 branch November 27, 2024 10:40
slimbuck added a commit to slimbuck/engine that referenced this pull request Nov 27, 2024
@slimbuck
Support compressed spherical harmonics (playcanvas#7143)
66cbb9f
@willeastcott willeastcott mentioned this pull request Dec 2, 2024
Open
@vincentwoo
Copy link

very excited for this, hope it lands in supersplat live soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
area: graphics Graphics related issue enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slimbuck @vincentwoo @willeastcott @mvaligursky