-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further gsplat shader refinements #7185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvaligursky
reviewed
Dec 9, 2024
// stores the camera and clip space position of the gaussian center | ||
struct SplatCenter { | ||
vec3 view; // center in view space | ||
vec4 proj; // center in clip space | ||
mat4 modelView; // model-view matrix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With clustered lighting, I had precision issue when a mat4 was stored in a struct, so I had to move it out. Not sure it would have the same impact here, likely not as shadow flickering is a specific issue.
mvaligursky
approved these changes
Dec 9, 2024
willeastcott
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #7169 and further refines the chunk layout for gsplat material:
SplatSource
- stores the splat's data uv, id and render orderSplatCenter
- stores the splat's center in camera and clip spaceSplatCorner
- stores the splat's corner offset (from center) in clip space and the corner uvinitSource
,initCenter
andinitCorner
populate the respective structures and are placed in their own chunks for easy customisationAlso:
tex_params
uniform with call to glsltextureSize