Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide component constructors #7203

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Hide component constructors #7203

merged 2 commits into from
Dec 17, 2024

Conversation

willeastcott
Copy link
Contributor

@willeastcott willeastcott commented Dec 16, 2024 •
edited
Loading

  • Hide all component constructors from the docs (since you should never create components via constructor and use addComponent instead).
  • Delete a few 'useless' constructors.
  • Convert some more properties to class fields.

I confirm I have read the contributing guidelines and signed the Contributor License Agreement.

@willeastcott willeastcott self-assigned this Dec 16, 2024
@willeastcott willeastcott merged commit 4dc7939 into main Dec 17, 2024
8 checks passed
@willeastcott willeastcott deleted the hideconstructor branch December 17, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slimbuck slimbuck slimbuck approved these changes

@mvaligursky mvaligursky Awaiting requested review from mvaligursky

Assignees

@willeastcott willeastcott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@willeastcott @slimbuck