Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle camera position and focus #249

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Handle camera position and focus #249

merged 2 commits into from
Oct 18, 2023

Conversation

slimbuck
Copy link
Member

This PR:

  • fixes handling of argument camera position, which wasn't being used correctly with splats
  • added similar cameraFocus param

@slimbuck slimbuck added the bug Something isn't working label Oct 18, 2023
@slimbuck slimbuck requested a review from a team October 18, 2023 14:56
@slimbuck slimbuck self-assigned this Oct 18, 2023
@slimbuck slimbuck merged commit 74a7965 into main Oct 18, 2023
@slimbuck slimbuck deleted the camera-placement branch October 18, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slimbuck @willeastcott