Cleanup #298
Merged
Cleanup #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kpal81xd
commented
May 29, 2024
•
kpal81xd
commented
- Sets default develop script to use debug engine (skips terser also)
- Proper importing of PCUI
- Updated playcanvas
- Removed unused modules
- Reordered tsconfig
- Refactored custom plugin
- Removed caching and use unbundled engine version for treeshaking
kpal81xd
requested review from
slimbuck and
willeastcott
and removed request for
slimbuck
|
Looks like you've removed the ability to specify custom PCUI package for development, i.e.: |
kungfooman
reviewed
May 30, 2024
willeastcott
approved these changes
May 30, 2024
|
Isn't pcui remapping still broken since you're importing directly from |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.