Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct color box pop-up position #354

Merged
merged 1 commit into from
May 14, 2024
Merged

fix: Correct color box pop-up position #354

merged 1 commit into from
May 14, 2024

Conversation

missingtears
Copy link
Contributor

No description provided.

@willeastcott
Copy link
Contributor

Thanks for the PR! Can you add a PR description please? I'm particularly interested in what scenario the current picker positioning breaks.

@missingtears
Copy link
Contributor Author

missingtears commented May 14, 2024 •
edited
Loading

image
When the color control is on the right side of the page, the position of the pop-up box is reduced by the width of the mask, and it moves to the far left.
image

@willeastcott
Copy link
Contributor

Thanks for the fix! 🙏

@willeastcott willeastcott merged commit 80b3a78 into playcanvas:main May 14, 2024
6 checks passed
@willeastcott
Copy link
Contributor

@missingtears This is now deployed as part of v4.4.0.

@willeastcott willeastcott mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willeastcott willeastcott willeastcott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@missingtears @willeastcott