Fix item import (#511)

* Version update

* fix include sorting

* change handling of important data

* update changelog

* change default values

* fix cs

Adapter/PlentymarketsAdapter/ReadApi/Item.php

@@ -31,15 +31,15 @@ class Item extends ApiAbstract
      */
     private $variationHelper;
 
-    private $attributes = [];
+    private $attributes = false;
 
-    private $barcodes = [];
+    private $barcodes = false;
 
-    private $propertyGroups = [];
+    private $propertyGroups = false;
 
-    private $propertyNames = [];
+    private $properties = false;
 
-    private $availabilities = [];
+    private $availabilities = false;
 
     /**
      * @var array
@@ -189,7 +189,7 @@ private function addAdditionalData(array &$elements)
 
     private function getAttributes()
     {
-        if (empty($this->attributes)) {
+        if (empty($this->attributes) && !is_array($this->attributes)) {
             $this->attributes = $this->itemAttributesApi->findAll();
         }
 
@@ -198,7 +198,7 @@ private function getAttributes()
 
     private function getBarcodes()
     {
-        if (empty($this->barcodes)) {
+        if (empty($this->barcodes) && !is_array($this->barcodes)) {
             $this->barcodes = $this->itemBarcodeApi->findAll();
         }
 
@@ -207,7 +207,7 @@ private function getBarcodes()
 
     private function getPropertyGroups()
     {
-        if (empty($this->propertyGroups)) {
+        if (empty($this->propertyGroups) && !is_array($this->propertyGroups)) {
             $this->propertyGroups = $this->itemsPropertyGroupsApi->findAll();
         }
 
@@ -216,7 +216,7 @@ private function getPropertyGroups()
 
     private function getProperties()
     {
-        if (empty($this->properties)) {
+        if (empty($this->properties) && !is_array($this->properties)) {
             $this->properties = $this->itemsPropertyNamesApi->findAll();
         }
 
@@ -225,7 +225,7 @@ private function getProperties()
 
     private function getAvailabilities()
     {
-        if (empty($this->availabilities)) {
+        if (empty($this->availabilities) && !is_array($this->availabilities)) {
             $this->availabilities = $this->availabilitiesApi->findAll();
         }
 

CHANGELOG.md

@@ -4,6 +4,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [## [unreleased]]
 ### Fixed
+- fix handling of important data on item sync (@lacodimizer)
 - fix tax handling on order export (@lacodimizer)
 - fixed wrong float cast (@ArvatisJohannes)