Payment notice fix (#496)

* optional attribute type * remove notice * styleCi
plentymarkets · Jun 21, 2019 · d450897 · d450897
1 parent 055bbf4
commit d450897
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Adapter/PlentymarketsAdapter/ResponseParser/Product/Variation/VariationResponseParser.php b/Adapter/PlentymarketsAdapter/ResponseParser/Product/Variation/VariationResponseParser.php
@@ -533,6 +533,10 @@ private function getPropertiesAsAttribute(array $properties): array
          * @var Attribute $attribute
          */
         foreach ($properties as $property) {
+            if (!isset($property['relationValues'][0])) {
+                continue;
+            }
+
             $attribute = new Attribute();
             $attribute->setKey('propertyId' . $property['propertyId']);
             $attribute->setValue($property['relationValues'][0]['value']);

diff --git a/Adapter/ShopwareAdapter/ResponseParser/Payment/PaymentResponseParser.php b/Adapter/ShopwareAdapter/ResponseParser/Payment/PaymentResponseParser.php
@@ -60,8 +60,6 @@ public function parse(array $element): array
         );
 
         if ($isMappedPaymentIdentity) {
-            $this->logger->notice('paymentidentity' . $paymentIdentifier->getObjectIdentifier() . ' ist not mapped');
-
             return [];
         }
-Original file line number
+Diff line change
@@ Expand Up / @@ -60,8 +60,6 @@ public function parse(array $element): array @@
             );
             if ($isMappedPaymentIdentity) {
-                $this->logger->notice('paymentidentity' . $paymentIdentifier->getObjectIdentifier() . ' ist not mapped');
                 return [];
             }
@@ Expand Down @@