net: Enhance observation management with ETag tracking #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces an enhancement to the observation mechanism in the network module by implementing ETag tracking. The latest ETag value associated with each observation is now stored in the internal representation. With this update, each incoming message containing the ETag CoAP option automatically updates the ETag value for the relevant observation. When an observation is canceled, the stored ETag value is utilized. When the server detects a valid ETag match, it now responds with a VALID code and an empty payload instead of resending the content of the resource. This optimization minimizes unnecessary data transfer and reduces network load.
Danielius1922
force-pushed
the
adam/feature/etag
branch
from
443f67c
to
906eb11
Compare
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
==========================================
+ Coverage 72.16% 72.26% +0.10%
==========================================
Files 70 70
Lines 5461 5470 +9
==========================================
+ Hits 3941 3953 +12
+ Misses 1123 1120 -3
Partials 397 397
|
jkralik
reviewed
Aug 8, 2023
net/observation/handler.go
Outdated
| @@ -240,6 +251,9 @@ func (o *Observation[C]) wantBeNotified(r *pool.Message) bool { | |||
| if ValidSequenceNumber(o.private.obsSequence, obsSequence, o.private.lastEvent, now) { | |||
| o.private.obsSequence = obsSequence | |||
| o.private.lastEvent = now | |||
| if etag, err := r.ETag(); err == nil { | |||
| o.private.etag = etag | |||
There was a problem hiding this comment.
use copy instead of assignation -> the underlayer buffer could be reused.
on new observation preallocate buffer with 8 bytes
There was a problem hiding this comment.
copy() copies works based on length not capacity, so if the lengths do not match I have to allocate a new slice
Danielius1922
force-pushed
the
adam/feature/etag
branch
from
83b1eb9
to
1bc3811
Compare
jkralik
approved these changes
Aug 8, 2023
|
Kudos, SonarCloud Quality Gate passed! |
HRogge
pushed a commit
to HRogge/go-coap
that referenced
this pull request
Oct 26, 2023
* net: Enhance observation management with ETag tracking This commit introduces an enhancement to the observation mechanism in the network module by implementing ETag tracking. The latest ETag value associated with each observation is now stored in the internal representation. With this update, each incoming message containing the ETag CoAP option automatically updates the ETag value for the relevant observation. When an observation is canceled, the stored ETag value is utilized. When the server detects a valid ETag match, it now responds with a VALID code and an empty payload instead of resending the content of the resource. This optimization minimizes unnecessary data transfer and reduces network load. --------- Co-authored-by: Jozef Kralik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces an enhancement to the observation mechanism in the network module by implementing ETag tracking. The latest ETag value associated with each observation is now stored in the internal representation.
With this update, each incoming message containing the ETag CoAP option automatically updates the ETag value for the relevant observation. When an observation is canceled, the stored ETag value is utilized. When the server detects a valid ETag match, it now responds with a VALID code and an empty payload instead of resending the content of the resource. This optimization minimizes unnecessary data transfer and reduces network load.