Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to configure RestAPI caching operations. #183

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

folix-01
Copy link
Member

Change the negotiation order for caching operations ruleset for RestAPI Services

@mister-roboto
Copy link

@folix-01 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@folix-01
Copy link
Member Author

@jenkins-plone-org please run jobs

@folix-01
Copy link
Member Author

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@folix-01 @cekk It is already possible to associate a cache ruleset with a specific REST service in ZCML, like this:

https://github.com/plone/plone.restapi/blob/682567a86b9fc022fbad32e27906475c5410eee1/src/plone/restapi/services/multilingual/configure.zcml#L26-L28

Is it really necessary to add another way to do it? If not I'd prefer to keep things simpler.

Also, this is a low-level package that must not have a hard dependency on anything from plone.app.*. So it's a problem to import from plone.app.caching without making it conditional. (To put it in other words: It must remain possible to create a Plone site that has plone.rest installed but not plone.app.caching.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants