-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shifting from .md to html in Nuclia #881
base: nuclia_widget
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions. Otherwise this looks good.
Ahh yes, |
Yes, but why do we get |
I guess the fix might not have been synced with |
Ah, yes, that would do it. Let me do that now, and we can take another look. Also, one training will be added soon (I hope) and another will go away, so that synch will need to happen again. |
@justdaksh done! Pull and let's have a look together. |
yay! URLs don't break anymore. |
We still have CI failure, but let's handle that in the base branch PR in #792 (comment) |
CI passed in base PR, updated base branch here and resolved conflicts. We'll see if that resolves the CI issue. |
CI passes. That leaves the breadcrumb issue. Also I updated the RTD PR preview URL slug, so it is now at: https://plone-training--881.org.readthedocs.build/ |
@stevepiercy Nuclia Knowledge Base has now been indexed with HTML
Issues
📚 Documentation preview 📚: https://plone-training--881.org.readthedocs.build/