-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommender.py for FastAPI #100
Conversation
mini-projects/movie-rec-system/movie_rec_system/recommendation/recommender.py
Outdated
Show resolved
Hide resolved
mini-projects/movie-rec-system/movie_rec_system/recommendation/recommender.py
Outdated
Show resolved
Hide resolved
Hi @lfunderburk Can you take a look at what I have so far? My main concern regards my comment on how we would connect to the S3 Bucket using Lambda. Besides that, I think the main |
mini-projects/movie-rec-system/movie_rec_system/recommendation/recommender.py
Outdated
Show resolved
Hide resolved
Please navigate to the Go to |
Hi @jpjon Did a bit of code clean up, type checking, pydantic modelling and added some testing To execute tests
From the Docker container we don't want to specify the path, we should be running things from the project's root directory (in this case Please execute the app as follows
Visit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To do:
- Run the tests, there are one or two warnings. See if you can fix them
- Add a test under
test/test_app.py
to check that a given movie is returning the desired result - Think of other ways the user might interact with the api - does it make sense to add another entry point?
…iven movie to return desired result
Changed made to fix warnings: Replaced @validator with @field_validator: https://events.bizzabo.com/458007/settings/registration/1eaNwY9AETInoqcCd_pBC3mdpyVozaTeGSNDrqw3yMsJPmiZu8MIS4Fbc0Qmsa1f Added additional test for validating response: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test coverage passes with new upgrades to pyproject.toml and app.py
Awesome!
Describe your changes
Created the
.py
file for the recommender that FastAPI will reference to.Issue number
#99
Closes #99
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://ploomber-sql--100.org.readthedocs.build/en/100/