Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Core): always set scheduler_key #40

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

stonebuzz
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

I'm not sure why, when the plugin checks the URL requested (to assign the key from the hook) only the first call to the plugin (init) works, all subsequent calls do not validate the URL check and so the licence is never given to the schedule

front/planning.php -> /front/planning.php  {"user":"2@stanislas-Caen-Desktop"} 
found  {"user":"2@stanislas-Caen-Desktop","mem_usage":"0.000\", 3.04Mio)"} 
true  {"user":"2@stanislas-Caen-Desktop","mem_usage":"0.000\", 3.04Mio)"} 


front/planning.php -> /plugins/vip/vip.js.php?v=3900982296f718ac20eeab8b75ee6669746a4aaa  {"user":"2@stanislas-Caen-Desktop"} 
front/reservation.php -> /plugins/vip/vip.js.php?v=3900982296f718ac20eeab8b75ee6669746a4aaa  {"user":"2@stanislas-Caen-Desktop","mem_usage":"0.000\", 3.04Mio)"} 
/front/computer.form.php -> /plugins/vip/vip.js.php?v=3900982296f718ac20eeab8b75ee6669746a4aaa  {"user":"2@stanislas-Caen-Desktop","mem_usage":"0.000\", 3.04Mio)"} 
/front/monitor.form.php -> /plugins/vip/vip.js.php?v=3900982296f718ac20eeab8b75ee6669746a4aaa  {"user":"2@stanislas-Caen-Desktop","mem_usage":"0.000\", 3.04Mio)"} 
/front/networkequipment.form.php -> /plugins/vip/vip.js.php?v=3900982296f718ac20eeab8b75ee6669746a4aaa  {"user":"2@stanislas-Caen-Desktop","mem_usage":"0.000\", 3.04Mio)"} 
/front/peripheral.form.php -> /plugins/vip/vip.js.php?v=3900982296f718ac20eeab8b75ee6669746a4aaa  {"user":"2@stanislas-Caen-Desktop","mem_usage":"0.000\", 3.04Mio)"} 
/front/phone.form.php -> /plugins/vip/vip.js.php?v=3900982296f718ac20eeab8b75ee6669746a4aaa  {"user":"2@stanislas-Caen-Desktop","mem_usage":"0.000\", 3.04Mio)"} 
/front/printer.form.php -> /plugins/vip/vip.js.php?v=3900982296f718ac20eeab8b75ee6669746a4aaa  {"user":"2@stanislas-Caen-Desktop","mem_usage":"0.000\", 3.04Mio)"} 
/front/software.form.php -> /plugins/vip/vip.js.php?v=3900982296f718ac20eeab8b75ee6669746a4aaa  {"user":"2@stanislas-Caen-Desktop","mem_usage":"0.000\", 3.04Mio)"} 
false  {"user":"2@stanislas-Caen-Desktop","mem_usage":"0.000\", 3.04Mio)"} 

Screenshots (if appropriate):

@stonebuzz stonebuzz requested review from Rom1-B and cconard96 January 9, 2025 10:34
@stonebuzz stonebuzz self-assigned this Jan 9, 2025
@stonebuzz stonebuzz added the bug Something isn't working label Jan 9, 2025
@stonebuzz stonebuzz mentioned this pull request Jan 9, 2025
2 tasks
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK

@stonebuzz stonebuzz merged commit 59f8436 into main Jan 15, 2025
3 checks passed
@stonebuzz stonebuzz deleted the fix_scheduler_key_hook branch January 15, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message using Advancedplanning
3 participants