Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refractor phpstan level 5 #408

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Refractor phpstan level 5 #408

merged 5 commits into from
Jan 20, 2025

Conversation

RomainLvr
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

Refactor plugin in phpstan level 5

@RomainLvr RomainLvr requested review from stonebuzz and Rom1-B January 17, 2025 17:11
@RomainLvr RomainLvr self-assigned this Jan 17, 2025
Rom1-B
Rom1-B requested changes Jan 20, 2025
View reviewed changes
front/signature.php Outdated Show resolved Hide resolved
inc/link.class.php Show resolved Hide resolved
inc/profile.class.php Outdated Show resolved Hide resolved
inc/reception.class.php Show resolved Hide resolved
@RomainLvr RomainLvr mentioned this pull request Jan 20, 2025
Merged
4 tasks
Rom1-B
Rom1-B requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@Rom1-B Rom1-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates the composer.json file:

‘phpstan/phpstan‘:’^2.1’,
‘phpstan/phpstan-deprecation-rules": “^2.0”,

inc/order_item.class.php Outdated Show resolved Hide resolved
inc/profile.class.php Outdated Show resolved Hide resolved
inc/reception.class.php Outdated Show resolved Hide resolved
@Rom1-B Rom1-B merged commit b204915 into pluginsGLPI:main Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rom1-B Rom1-B Rom1-B approved these changes

@stonebuzz stonebuzz stonebuzz approved these changes

Assignees

@RomainLvr RomainLvr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RomainLvr @stonebuzz @Rom1-B