Protection against NPE #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding extra checks to protect against NPE
|
Unit test may be added. |
|
Should I add this unit test or do you need a test case from me? |
|
Yes, it will be nice to have a unit test. |
|
How could I do that? because I'm kind of new and don't know exactly how to do it. |
|
You may create a f8oe src/test/java/org/docx4j/model/listnumbering/ListNumberingDefinitionTest.java with unit test. |
This is the unit test for commit plutext#217
This document is necessary for unit test ListNumberingDefinitionTest.java for commit plutext#217
|
I've created the unit test src/test/java/org/docx4j/model/listnumbering/ListNumberingDefinitionTest.java Let me know your feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding extra checks to protect against NPE