Make codechecker happy

pmaneggia · Nov 12, 2023 · 0b00950 · 0b00950
1 parent c27f9ea
commit 0b00950
Show file tree

Hide file tree

Showing 8 changed files with 32 additions and 31 deletions.
diff --git a/amd/build/visualiseDependencies.min.js b/amd/build/visualiseDependencies.min.js
diff --git a/amd/build/visualiseDependencies.min.js.map b/amd/build/visualiseDependencies.min.js.map
diff --git a/amd/src/visualiseDependencies.js b/amd/src/visualiseDependencies.js
@@ -166,10 +166,11 @@ function addFilterDropShadow() {
  */
 function determineSvgSize() {
     let svg = document.querySelector('svg.availdep');
-    let width = svg.parentNode.clientWidth;
+    console.log('Paola element ' + document.querySelector('div.drawercontent').clientWidth);
+    //let width = svg.parentNode.parentNode.clientWidth;
+    let width = document.querySelector('div.drawercontent').clientWidth;
     let orientation = screen.orientation?.type;
-    let height = orientation === "portrait-primary" ? width * 1.3 : width * 0.6;
-    svgWidth = width;
+    let height = orientation === "landscape-primary" ? width * 1.3 : width * 0.6;
     return {width, height};
 }
 

diff --git a/block_availdep.php b/block_availdep.php
@@ -43,7 +43,7 @@ public function init() {
      * {@inheritDoc}
      */
     public function applicable_formats() {
-        return array('course-view' => true);
+        return ['course-view' => true];
     }
 
     /**
@@ -58,7 +58,7 @@ public function get_content() {
             return $this->content;
         }
 
-        $this->page->requires->js_call_amd('block_availdep/visualiseDependencies', 'init', array($courseid, 'yes'));
+        $this->page->requires->js_call_amd('block_availdep/visualiseDependencies', 'init', [$courseid, 'yes']);
 
         $data = new stdClass();
         $data->d3src = new moodle_url('/blocks/availdep/thirdparty/d3.v7.min.js');

diff --git a/classes/external/fetch_course_data.php b/classes/external/fetch_course_data.php
@@ -51,7 +51,7 @@ class fetch_course_data extends external_api {
      */
     public static function fetch_course_modules_with_names_and_dependencies_parameters() {
         return new external_function_parameters([
-            'courseid'    => new external_value(PARAM_INT, 'course id')
+            'courseid'    => new external_value(PARAM_INT, 'course id'),
         ]);
     }
 
@@ -83,7 +83,7 @@ function ($cm) use ($predecessors) {
                     'id' => $cm->id,
                     'name' => $cm->get_name(),
                     'depend' => $cm->availability,
-                    'predecessor' => $predecessors[$cm->id]
+                    'predecessor' => $predecessors[$cm->id],
                 ];
             }, $cmsnotdeletioninprogress);
     }
@@ -120,7 +120,7 @@ public static function fetch_course_modules_with_names_and_dependencies_returns(
             'id' => new external_value(PARAM_INT, 'course module id'),
             'name' => new external_value(PARAM_TEXT, 'module name', VALUE_OPTIONAL),
             'depend' => new external_value(PARAM_TEXT, 'availability conditions as json string', VALUE_OPTIONAL),
-            'predecessor' => new external_value(PARAM_INT, 'previous course module with completion')
+            'predecessor' => new external_value(PARAM_INT, 'previous course module with completion'),
         ]));
     }
 }
diff --git a/db/access.php b/db/access.php
@@ -24,16 +24,16 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$capabilities = array(
-    'block/availdep:addinstance' => array(
+$capabilities = [
+    'block/availdep:addinstance' => [
         'riskbitmask' => RISK_SPAM | RISK_XSS,
         'captype' => 'write',
         'contextlevel' => CONTEXT_BLOCK,
-        'archetypes' => array(
+        'archetypes' => [
             'editingteacher' => CAP_ALLOW,
-            'manager' => CAP_ALLOW
-        ),
+            'manager' => CAP_ALLOW,
+        ],
 
-        'clonepermissionsfrom' => 'moodle/site:manageblocks'
-    ),
-);
+        'clonepermissionsfrom' => 'moodle/site:manageblocks',
+    ],
+];
diff --git a/db/services.php b/db/services.php
@@ -25,27 +25,27 @@
 
 defined('MOODLE_INTERNAL') || die();
 
-$services = array(
-    'block_availdep_service'   => array(
-        'functions' => array (
+$services = [
+    'block_availdep_service'   => [
+        'functions' => [
             'block_availdep_fetch_course_modules_with_names_and_dependencies',
-        ),
+        ],
         'restrictedusers'   => 0,
         'enabled'           => 1,
         'shortname'         => 'block_availdep_service',
         'downloadfiles'     => 0,
-        'uploadfiles'       => 0
-    )
-);
+        'uploadfiles'       => 0,
+    ]
+];
 
-$functions = array(
-    'block_availdep_fetch_course_modules_with_names_and_dependencies' => array(
+$functions = [
+    'block_availdep_fetch_course_modules_with_names_and_dependencies' => [
         'classname'     => 'block_availdep\external\fetch_course_data',
         'methodname'    => 'fetch_course_modules_with_names_and_dependencies',
         'classpath'     => 'blocks/availdep/classes/external/fetch_course_data.php',
         'description'   => 'Retrieve course modules with ids and names.',
         'type'          => 'read',
         'ajax'          => true,
-        'loginrequired' => true
-    )
-);
+        'loginrequired' => true,
+    ]
+];
diff --git a/view.php b/view.php
@@ -43,7 +43,7 @@
 );
 $PAGE->navbar->add(get_string('pluginname', 'block_availdep'));
 
-$PAGE->requires->js_call_amd('block_availdep/visualiseDependencies', 'init', array($courseid, $full));
+$PAGE->requires->js_call_amd('block_availdep/visualiseDependencies', 'init', [$courseid, $full]);
 
 echo $OUTPUT->header();
 $renderable = new block_availdep\output\view_page($courseid, $full);