-
Notifications
You must be signed in to change notification settings - Fork 76
tests: add suppression for memcheck #1263
base: stable-1.13
Are you sure you want to change the base?
tests: add suppression for memcheck #1263
Conversation
1d0d4b5
to
fb91098
Compare
Codecov Report
@@ Coverage Diff @@
## stable-1.13 #1263 +/- ##
===============================================
- Coverage 95.52% 93.74% -1.79%
===============================================
Files 53 53
Lines 6755 4573 -2182
===============================================
- Hits 6453 4287 -2166
+ Misses 302 286 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this should be opened against stable-1.13 I think (@kilobyte reported the issue for 1.13)
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)
fb91098
to
f177676
Compare
good point, re-based. |
I had to add a commit (cherry-picked from master) with the PMDK version update, due to CI failure. |
WFM. |
c8a90ca
to
f5aba20
Compare
and use fixed Windows 2019
f5aba20
to
f59db44
Compare
for this PR to work (and the whole stable-1.13 branch), we'd have to apply 2 CI fixes: Windows workflow update and the newest PMDK installed (both cherry-picked here). I'm not sure if we want (and need) to do this now - we're applying these fixes into stable-1.9, and we can wait for them to be merged, bottom to top. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)
ref. #1262
This change is