libcxl: remove nonexistent symbol declaration #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was added in d25dc6d but has never had an implementation, and new ld.lld by default fails to link when a symbol doesn't exist: ld.lld: error: version script assignment of 'LIBCXL_3' to symbol 'cxl_mapping_get_region' failed: symbol not defined clang: error: linker command failed with exit code 1 (use -v to see invocation)
hswong3i
added a commit
to alvistack/pmem-ndctl
that referenced
this pull request
Oct 11, 2024
git clean -xdf
tar zcvf ../ndctl_80.orig.tar.gz --exclude=.git .
debuild -uc -us
cp ndctl.spec ../ndctl_80-1.spec
cp ndctl.rpmlintrc /osc/home\:alvistack/pmem-ndctl-80/
cp ../ndctl*80*.{gz,xz,spec,dsc} /osc/home\:alvistack/pmem-ndctl-80/
rm -rf ../*ndctl*80*.* ../*daxctl*80*.* ../*libcxl*80*.*
See pmem#267
See pmem#268
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/pmem-ndctl
that referenced
this pull request
Oct 11, 2024
git clean -xdf
tar zcvf ../ndctl_80.orig.tar.gz --exclude=.git .
debuild -uc -us
cp ndctl.spec ../ndctl_80-1.spec
cp ndctl.rpmlintrc /osc/home\:alvistack/pmem-ndctl-80/
cp ../ndctl*80*.{gz,xz,spec,dsc} /osc/home\:alvistack/pmem-ndctl-80/
rm -rf ../*ndctl*80*.* ../*daxctl*80*.* ../*libcxl*80*.*
See pmem#267
See pmem#268
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/pmem-ndctl
that referenced
this pull request
Oct 11, 2024
git clean -xdf
tar zcvf ../ndctl_80.orig.tar.gz --exclude=.git .
debuild -uc -us
cp ndctl.spec ../ndctl_80-1.spec
cp ndctl.rpmlintrc /osc/home\:alvistack/pmem-ndctl-80/
cp ../ndctl*80*.{gz,xz,spec,dsc} /osc/home\:alvistack/pmem-ndctl-80/
rm -rf ../*ndctl*80*.* ../*daxctl*80*.* ../*libcxl*80*.*
See pmem#267
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/pmem-ndctl
that referenced
this pull request
Oct 11, 2024
git clean -xdf
tar zcvf ../ndctl_80.orig.tar.gz --exclude=.git .
debuild -uc -us
cp ndctl.spec ../ndctl_80-1.spec
cp ndctl.rpmlintrc /osc/home\:alvistack/pmem-ndctl-80/
cp ../ndctl*80*.{gz,xz,spec,dsc} /osc/home\:alvistack/pmem-ndctl-80/
rm -rf ../*ndctl*80*.* ../*daxctl*80*.* ../*libcxl*80*.*
See pmem#267
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
hswong3i
added a commit
to alvistack/pmem-ndctl
that referenced
this pull request
Oct 11, 2024
git clean -xdf
tar zcvf ../ndctl_80.orig.tar.gz --exclude=.git .
debuild -uc -us
cp ndctl.spec ../ndctl_80-1.spec
cp ndctl.rpmlintrc /osc/home\:alvistack/pmem-ndctl-80/
cp ../ndctl*80*.{gz,xz,spec,dsc} /osc/home\:alvistack/pmem-ndctl-80/
rm -rf ../*ndctl*80*.* ../*daxctl*80*.* ../*libcxl*80*.*
See pmem#267
Revert pmem@9873123
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
|
Thanks for the fix. I need a Signed-off-by tag from you to post the patch to our mailing list and merge in the next release. Signed-off-by: Random J Developer [email protected] If you'll send me that I'll add it to the patch, post it, and get it merged. Thanks! |
|
I see the closed on this, not clear to me why. I still intend to fix if I can rm that past symbol. |
|
I can't sign things, and the fix is trivial so I'm sure someone else will do it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was added in d25dc6d but has never had an implementation, and new ld.lld by default fails to link when a symbol doesn't exist:
ld.lld: error: version script assignment of 'LIBCXL_3' to symbol 'cxl_mapping_get_region' failed: symbol not defined
clang: error: linker command failed with exit code 1 (use -v to see invocation)