Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Merging PMDebugger into Pmemcheck #83

Open
wants to merge 11 commits into
base: pmem-3.15
Choose a base branch
from
Open

Merging PMDebugger into Pmemcheck #83

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f83929f
original version
dibang2008 Apr 27, 2021
d0df662
just add new structure (store information array)
dibang2008 Apr 28, 2021
f0f2624
modify the algorithm of trace_pmem_store()
dibang2008 Apr 29, 2021
1ec6030
modify the algorithm of do_flush
dibang2008 May 2, 2021
263d2af
modify the algorithm of do_fence
dibang2008 May 5, 2021
93a2ec5
mini fix do_flush
dibang2008 May 8, 2021
58e2ccb
fix bugs and pass the simple verification (perl tests/vg_regtest pmem…
dibang2008 May 8, 2021
e4db72f
(1) format codes; (2) add a document to introduce what has change and…
dibang2008 May 12, 2021
f600a97
(1) Dynamically grow the array structure; (2) unify this code; (3) re…
dibang2008 May 27, 2021
0f26388
shorten codes and remove comments
dibang2008 Jun 5, 2021
ab4a7d1
align structure arr_md
dibang2008 Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.vscode/
*.o

.DS_Store
# /
/.in_place
/.vs
Expand Down
16 changes: 15 additions & 1 deletion pmemcheck/pmc_include.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,24 @@

#ifndef PMC_INCLUDE_H
#define PMC_INCLUDE_H
/** Metadata structure for store information array */
struct arr_md {
UWord end_index; //Index of current free metadata
Addr min_addr;
Addr max_addr;
UWord start_index;
enum flushed_state
{
NO_FLUSHED,
PART_FLUSHED,
ALL_FLUSHED,
} state;
};


/** Single store to memory. */
struct pmem_st {
Bool is_delete;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, please ensure that is data structure is as compact as possible. If the Bool type is 1 byte, then, as @krzycz pointed out, this wastes tons of memory for alignment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this 'is_delete' flag and now I use 'address size = 0' to mark a persistent memory info as deleted

Addr addr;
ULong size;
ULong block_num;
Expand All @@ -33,7 +48,6 @@ struct pmem_st {
/*------------------------------------------------------------*/
/*--- Common functions ---*/
/*------------------------------------------------------------*/

/* Check if the given region is in the set. */
UWord is_in_mapping_set(const struct pmem_st *region, OSet *region_set);

Expand Down
Loading