Skip to content

Commit

Permalink
Don't carelessly expose internal-use constant to the API
Browse files Browse the repository at this point in the history
if we want to actually expose these, we should probably consider putting them in a separate class.
  • Loading branch information
dktapps committed Dec 4, 2021
1 parent db49000 commit 13cb51b
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/Binary.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,13 +39,13 @@
use const PHP_INT_MAX;

class Binary{
public const SIZEOF_BYTE = 1;
public const SIZEOF_SHORT = 2;
public const SIZEOF_INT = 4;
public const SIZEOF_LONG = 8;
private const SIZEOF_BYTE = 1;
private const SIZEOF_SHORT = 2;
private const SIZEOF_INT = 4;
private const SIZEOF_LONG = 8;

public const SIZEOF_FLOAT = 4;
public const SIZEOF_DOUBLE = 8;
private const SIZEOF_FLOAT = 4;
private const SIZEOF_DOUBLE = 8;

public static function signByte(int $value) : int{
return $value << 56 >> 56;
Expand Down

0 comments on commit 13cb51b

Please sign in to comment.