Skip to content

Commit

Permalink
auto-approve: drop pull_request_review trigger
Browse files Browse the repository at this point in the history
this doesn't work for PRs from forks, since fork PRs don't have access to repo secrets.

we'll need some more advanced mechanism to avoid redundant reviews, but that's a job for another time.
  • Loading branch information
dktapps authored Nov 25, 2024
1 parent a9787f0 commit 8cdc7d7
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/team-pr-auto-approve.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ on:
- opened
- reopened
- ready_for_review
pull_request_review:
types: dismissed
- synchronize

jobs:
dispatch:
Expand All @@ -36,4 +35,4 @@ jobs:
token: ${{ steps.generate-token.outputs.token }}
repository: ${{ github.repository_owner }}/RestrictedActions
event-type: auto_approve_collaborator_pr
client-payload: '{"repo": "${{ github.repository }}", "pull_request_id": "${{ github.event.pull_request.number }}", "reviewer_id": "${{ github.event.review.user.id || 0 }}" }'
client-payload: '{"repo": "${{ github.repository }}", "pull_request_id": "${{ github.event.pull_request.number }}", "reviewer_id": "0" }'

0 comments on commit 8cdc7d7

Please sign in to comment.