Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rollup): migrate commonjs to esmodule #2913

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jan 7, 2025

Summary

Check List

  • pnpm run fix:format for formatting code and docs

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 2:06pm

Copy link

codesandbox-ci bot commented Jan 7, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jan 7, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@2913

commit: 80cb410

Copy link

github-actions bot commented Jan 7, 2025

LiveCodes Preview in LiveCodes

Latest commit: 80cb410
Last updated: Jan 7, 2025 2:05pm (UTC)

Playground Link
React demo https://livecodes.io?x=id/85S8WDKHY

See documentations for usage instructions.

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check with diff -r?

@sukvvon
Copy link
Contributor Author

sukvvon commented Jan 7, 2025

Did you check with diff -r?

Yeah, i checked

@dai-shi dai-shi merged commit 5ff8f63 into pmndrs:main Jan 7, 2025
42 checks passed
@sukvvon sukvvon deleted the chore/cjs-to-esm-rollup branch January 8, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants