Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rollup): clarify variables, add a 'global' comment #2928

Merged
merged 3 commits into from
Jan 12, 2025

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Jan 12, 2025

Summary

Check List

  • pnpm run fix:format for formatting code and docs

Copy link

vercel bot commented Jan 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2025 6:09am

@sukvvon sukvvon changed the title chore(rollup): clarify variables chore(rollup): clarify variables, add global process Jan 12, 2025
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jan 12, 2025

Open in Stackblitz

More templates

npm i https://pkg.pr.new/jotai@2928

commit: 8709faf

@sukvvon sukvvon changed the title chore(rollup): clarify variables, add global process chore(rollup): clarify variables, add global Jan 12, 2025
Copy link

LiveCodes Preview in LiveCodes

Latest commit: 8709faf
Last updated: Jan 12, 2025 6:08am (UTC)

Playground Link
React demo https://livecodes.io?x=id/FMTT6USNQ

See documentations for usage instructions.

@sukvvon sukvvon changed the title chore(rollup): clarify variables, add global chore(rollup): clarify variables, add global comment Jan 12, 2025
@sukvvon sukvvon changed the title chore(rollup): clarify variables, add global comment chore(rollup): clarify variables, add a global comment Jan 12, 2025
@sukvvon sukvvon changed the title chore(rollup): clarify variables, add a global comment chore(rollup): clarify variables, add a 'global' comment Jan 12, 2025
@dai-shi dai-shi merged commit fed314b into pmndrs:main Jan 12, 2025
44 checks passed
@sukvvon sukvvon deleted the chore/clarify-variables-in-rollup-config branch January 12, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants