♻️ use inline plugin #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kris Baumgartner <[email protected]>
Signed-off-by: Kris Baumgartner <[email protected]>
Signed-off-by: Kris Baumgartner <[email protected]>
Signed-off-by: Kris Baumgartner <[email protected]>
Signed-off-by: Kris Baumgartner <[email protected]>
Signed-off-by: Kris Baumgartner <[email protected]>
Signed-off-by: Kris Baumgartner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently hot paths are optimized by hand including inlining functions and using bitwise operations, short circuits, etc. This makes it harder for contributors to read the code and modify the logic. To fix this I wrote a Esbuild plugin via Babel that will inline functions based on the comment annoatations.
/* @inline */marks a function be inlined anywhere it is used while/* @pure */indicates that the function does not mutate any non-local state allowing its state access to be safely combined with other inlined functions.This is the beginning of trying to work out having an easy to read but highly performant TS codebase so there will be some bumps but I am excited to expand on the idea.