Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated vendored motion controllers to ts #194

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

saitonakamura
Copy link
Contributor

@saitonakamura saitonakamura commented Oct 7, 2022

What

Migrated vendored MotionController and XRControllerModelFactory to ts. I wasn't sure before, but now decided that it's better to continue with our own vendored version of these stuff, cause it'll allow us to push it further in terms of stability and feature-richness. Previous thoughts can be found below

Right now it's a best-effort, and I'm not sure how to proceed. Main issue is that the issues why it was vendored in the first place was fixed since then and also typings improved, but new version haven't been released. I created an issue in the repo immersive-web/webxr-input-profiles#224, but I'm not sure if we should just give up.

The right way to do it would be to:

Checklist

  • Documentation updated
  • Storybook entry added
  • Ready to be merged

@vercel
Copy link

vercel bot commented Oct 7, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
three-stdlib ✅ Ready (Inspect) Visit Preview Dec 21, 2022 at 10:24AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 7, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 20d4997:

Sandbox Source
three-stdlib-ssr Configuration

@saitonakamura saitonakamura marked this pull request as ready for review December 21, 2022 10:21
@drcmda drcmda merged commit 697b6ba into pmndrs:main Dec 21, 2022
@github-actions
Copy link

🎉 This PR is included in version 2.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@saitonakamura saitonakamura deleted the migrate-motion-controllers-ts branch December 21, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants