fix: logic error in intent detection (#407)

pmndrs · Dec 6, 2021 · cffaba5 · cffaba5
1 parent c5267a9
commit cffaba5
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/.changeset/breezy-berries-serve.md b/.changeset/breezy-berries-serve.md
@@ -0,0 +1,5 @@
+---
+'@use-gesture/core': patch
+---
+
+fix: logic error in intent detection
diff --git a/packages/core/src/engines/Engine.ts b/packages/core/src/engines/Engine.ts
@@ -266,7 +266,7 @@ export abstract class Engine<Key extends GestureKey> {
       if (_step[1] === false) _step[1] = Math.abs(_m1) >= t1 && Math.sign(_m1) * t1
     }
 
-    state.intentional = _step[0] !== false || _step[0] !== false
+    state.intentional = _step[0] !== false || _step[1] !== false
 
     if (!state.intentional) return
 

diff --git a/test/drag.test.tsx b/test/drag.test.tsx
@@ -177,10 +177,11 @@ describe.each([
     fireEvent.pointerUp(element, { pointerId: 8 })
   })
 
-  test(`applying an axis SHOULDN'T start the gesture if gesture is not detected first in the right axis`, () => {
+  test(`applying an axis SHOULDN'T start the gesture if gesture is not detected first in the right axis`, async () => {
     rerender(<Component gestures={['Drag']} config={{ drag: { axis: 'x' } }} />)
     fireEvent.pointerDown(element, { pointerId: 81, clientX: 0, clientY: 0, buttons: 1 })
     fireEvent.pointerMove(element, { pointerId: 81, clientX: 0, clientY: 50, buttons: 1 })
+    await later()
     fireEvent.pointerMove(element, { pointerId: 81, clientX: 10, clientY: 0, buttons: 1 })
     expect(getByTestId(`${prefix}drag-dragging`)).toHaveTextContent('false')
     fireEvent.pointerUp(element, { pointerId: 81 })