Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): valtio.dev code display issue #1022

Merged
merged 3 commits into from
Dec 18, 2024
Merged

fix(website): valtio.dev code display issue #1022

merged 3 commits into from
Dec 18, 2024

Conversation

overthemike
Copy link
Collaborator

@overthemike overthemike commented Dec 18, 2024

Related Bug Reports or Discussions

Fixes #1019

Summary

Fixed the styling issue for the code example on valtio.dev.

Check List

  • [x ] pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:20am

Copy link

codesandbox-ci bot commented Dec 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Dec 18, 2024

Size Change: 0 B

Total Size: 13.6 kB

ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 63 B
./dist/esm/react.mjs 691 B
./dist/esm/react/utils.mjs 257 B
./dist/esm/utils.mjs 68 B
./dist/esm/vanilla.mjs 2.35 kB
./dist/esm/vanilla/utils.mjs 3.15 kB
./dist/index.js 243 B
./dist/react.js 681 B
./dist/react/utils.js 278 B
./dist/utils.js 248 B
./dist/vanilla.js 2.38 kB
./dist/vanilla/utils.js 3.19 kB

compressed-size-action

Copy link

pkg-pr-new bot commented Dec 18, 2024

Open in Stackblitz

More templates

npm i https://pkg.pr.new/valtio@1022

commit: 0b4403c

@overthemike
Copy link
Collaborator Author

I'm not sure why the build isn't working. It's complaining with a 404. Any thoughts @dai-shi?

@overthemike overthemike changed the title 1019 1019 - valtio.dev code display issue Dec 18, 2024
@dai-shi dai-shi changed the title 1019 - valtio.dev code display issue fix(website): valtio.dev code display issue Dec 18, 2024
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-shi dai-shi merged commit f6e424d into main Dec 18, 2024
29 checks passed
@dai-shi dai-shi deleted the 1019 branch December 18, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants