Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABI: update mpi_abi.h with upstream #6951

Merged
merged 1 commit into from
Mar 29, 2024
Merged

ABI: update mpi_abi.h with upstream #6951

merged 1 commit into from
Mar 29, 2024

Conversation

dalcinl
Copy link
Contributor

@dalcinl dalcinl commented Mar 28, 2024

Pull Request Description

  • Remove MPIX_REAL1
  • Update values of predefined attribute keys
  • Some MPI_T constants are now bitsets.

cf. mpi-forum/mpi-abi-stubs#35

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

* Remove MPIX_REAL1
* Update values of predefined attribute keys
* Some MPI_T constants are now bitsets.
@dalcinl
Copy link
Contributor Author

dalcinl commented Mar 28, 2024

This PR and the stubs one has to be merged roughly at the same time, otherwise the automated CI tests for mpi4py+ABI would fail.
https://github.com/mpi4py/mpi4py-testing/actions/workflows/abi.yml

@hzhou
Copy link
Contributor

hzhou commented Mar 28, 2024

test:mpich/custom
config:mpi-abi

@hzhou hzhou self-requested a review March 28, 2024 21:25
Copy link
Contributor

@hzhou hzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge if tests are good.

@dalcinl
Copy link
Contributor Author

dalcinl commented Mar 29, 2024

@hzhou Can you please click the merge button in mpi-forum/mpi-abi-stubs#35 once you do the merge here?

@hzhou
Copy link
Contributor

hzhou commented Mar 29, 2024 via email

@hzhou hzhou merged commit 9f2c4c9 into pmodels:main Mar 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants