Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: Update libfabric #7088

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

raffenet
Copy link
Contributor

@raffenet raffenet commented Aug 7, 2024

Pull Request Description

Include ofiwg/libfabric#10223. Fixes verbs provider compilation on FreeBSD systems.

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

@raffenet
Copy link
Contributor Author

raffenet commented Aug 7, 2024

test:mpich/submodules

@hzhou
Copy link
Contributor

hzhou commented Aug 7, 2024

So now verbs works on FreeBSD?

@raffenet
Copy link
Contributor Author

raffenet commented Aug 7, 2024

So now verbs works on FreeBSD?

Yes, it can successfully build 😄. I haven't yet run the testsuite. Maybe a custom job string can try it?

@hzhou
Copy link
Contributor

hzhou commented Aug 7, 2024

test:mpich/custom/pipeline
label: freebsd64
env: FI_PROVIDER=verbs

@hzhou
Copy link
Contributor

hzhou commented Aug 8, 2024

test:mpich/custom/pipeline
label: freebsd64
netmod: ch4:ofi
env: FI_PROVIDER=verbs

Looks like we don't have Infiniband on freebsd or it didn't find it.

@hzhou
Copy link
Contributor

hzhou commented Aug 8, 2024

test:mpich/custom/pipeline
label: freebsd64
netmod: ch4:ofi

@raffenet
Copy link
Contributor Author

raffenet commented Aug 8, 2024

test:mpich/custom/pipeline label: freebsd64 netmod: ch4:ofi env: FI_PROVIDER=verbs

Looks like we don't have Infiniband on freebsd or it didn't find it.

Yeah, ibstat reports this:

pmrs-freebsd64-240-02% ibstat
ibwarn: [22440] umad_init: can't read ABI version from sys.class.infiniband_mad.abi_version (No such file or directory): is ibcore module loaded?
ibpanic: [22440] main: can't init UMAD library: No such file or directory

@hzhou
Copy link
Contributor

hzhou commented Aug 9, 2024

test:mpich/custom/pipeline
label: freebsd64
netmod: ch4:ofi

@raffenet raffenet requested a review from hzhou August 16, 2024 19:06
Copy link
Contributor

@hzhou hzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Include ofiwg/libfabric#10223. Fixes verbs
provider compilation on FreeBSD systems.
@raffenet raffenet force-pushed the libfabric-submodule branch from 92439ae to 69ed3ae Compare August 16, 2024 20:14
@raffenet raffenet merged commit b80d269 into pmodels:main Aug 16, 2024
0 of 4 checks passed
@raffenet raffenet added this to the mpich-4.2.3 milestone Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants