Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ch4: Fix anysrc recv cancel #7217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

raffenet
Copy link
Contributor

@raffenet raffenet commented Nov 14, 2024

Pull Request Description

Avoid recursively canceling partner requests for MPI_ANY_SOURCE recv operations. Fixes #7203.

Author Checklist

  • Provide Description
    Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • Commits Follow Good Practice
    Commits are self-contained and do not do two things at once.
    Commit message is of the form: module: short description
    Commit message explains what's in the commit.
  • Passes All Tests
    Whitespace checker. Warnings test. Additional tests via comments.
  • Contribution Agreement
    For non-Argonne authors, check contribution agreement.
    If necessary, request an explicit comment from your companies PR approval manager.

@raffenet
Copy link
Contributor Author

test:mpich/ch4/most

Copy link
Contributor

@hzhou hzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If we confirm this fixes user's issue on aurora, I think we can merge.

Avoid recursively canceling partner requests for MPI_ANY_SOURCE recv
operations. Fixes pmodels#7203.
@hzhou
Copy link
Contributor

hzhou commented Nov 22, 2024

@raffenet I located the issue. In -

if (!MPIR_Request_is_complete(*request) && !MPIDIG_REQUEST_IN_PROGRESS(*request)) {
MPIR_Request *nm_rreq = NULL;
mpi_errno = MPIDI_NM_mpi_irecv(buf, count, datatype, rank, tag, comm, attr,
av, &nm_rreq, *request);
MPIR_ERR_CHECK(mpi_errno);
/* if netmod recv is not matched yet, attach it to the shm request's partner */

The shm request got completed when we use MPIDI_OFI_CALL_RETRY for fi_trecv, and the progress between retry completed the request before we can set up the anysrc_partner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aurora: Segfaults when message arrvives via shm memory
2 participants