COMP: Fix build ensuring inner-build doesn't override the outer build #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures the project and its dependency are built using the expected compiler.
With this set of changes, the extension project now build on the Slicer build machine where we explicitly set
CC
andCXX
variables to/dev/null
and ensure the same compiler is used across all projects.It fixes the following error:
Source: https://slicer.cdash.org/viewBuildError.php?buildid=3001519
Summary:
Ensure inner-build doesn't override the outer build by setting the
EXTENSION_BUILD_SUBDIRECTORY
variable specific to the SuperBuild extension layout.Fix inner build ensuring the
Slicer_DIR
variable is propagated.Ensure the Git executable is consistently set and remove obsolete workaround. Note also that Subversion is not used anymore.
Ensure CMake options specific to CXX standard are propagated.
Remove obsolete
<proj>_USE_GIT_PROTOCOL
variable. It is now defined and set in theExternalProjectDependency
CMake module. Note also that the default is now set to "https" as GitHub removed unauthenticated access through the git protocol. See https://github.blog/2021-09-01-improving-git-protocol-security-github/Remove obsolete
MIDAS_PACKAGE_*
variables. Upload of extension is done using a different mechanism. See Slicer/Slicer@359f95c9b (COMP: Simplify extension package upload logic removing midas support
)Remove explicit and incorrect setting of
CMAKE_BUILD_TYPE
option. The option is set only for single-config CMake generator (e.g Unix Makefiles) after callinginclude(${Slicer_USE_FILE})
which indirectly includes theSlicerInitializeBuildType
CMake module.If these changes, the extension now build successfully:
References:
cc: @sjh26 @Sunderlandkyl