Skip to content
This repository has been archived by the owner on Apr 14, 2020. It is now read-only.

[WIP] Support of disputed_by and claimed_by #15

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

frodrigo
Copy link
Contributor

Try to implement #13

Add disputed_by and claimed_by to the output.

The idea is to have the alternative boundaries accepted by countries and rejected by countries.

@pnorman
Copy link
Owner

pnorman commented Aug 12, 2019

If I understand the docs, this is building a semicolon separated list out of information from multiple relations? Why not create an array?

@frodrigo
Copy link
Contributor Author

You are right, for direct use within Postgres array are better.

Switching to array.

@frodrigo frodrigo force-pushed the disputed_claim branch 2 times, most recently from 0b2a4d0 to 0c643a5 Compare August 15, 2019 15:18
@frodrigo
Copy link
Contributor Author

I make an user diary on osm.org about this https://www.openstreetmap.org/user/frodrigo/diary/390502

@pnorman
Copy link
Owner

pnorman commented Aug 26, 2019

Let me know when you're done making changes and it's ready for final review. I still need to run tests/etc.

@frodrigo
Copy link
Contributor Author

I am still unsure about the approach and the tags.

Nevertheless you can look at the others issues/pull request, there can be validated independently of this pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants