Added support for autocomplete in Zsh and clink solving #141 and #190

[waldekmastykarz]

Added support for autocomplete in Zsh and clink solving #141 and #190

[coveralls]

Coverage remained the same at 100.0% when pulling 786b75e on waldekmastykarz:completion-lua into a0b98c7 on SharePoint:dev.

[waldekmastykarz]

Merged manually

[VelinGeorgiev]

FYI: @waldekmastykarz , work like a charm (disclaimer: 'on my machine') :)!

cmder

[waldekmastykarz]

Excellent!

[waldekmastykarz]

Btw, looking closer at both screenshots @VelinGeorgiev I noticed that you've checked autocomplete in immersive mode (eg. after starting the CLI). What's added, is autocomplete directly in the shell, so in the cmder, you would for example type o365 spo <tab><tab> and cmder would list for you the available spo commands.

[VelinGeorgiev]

@waldekmastykarz, my cmder does not behave as expected:
cmder version status: 171025 preview (ConEmu 171025 [64])

o365 spo <tab><tab> still shows the available folders in the current directory instead of cli commands. I can log more detailed issue and also take a look at the code since I use windows.

[waldekmastykarz]

Have you followed the setup instructions as described in https://sharepoint.github.io/office365-cli/concepts/completion/#clink-cmder?

[VelinGeorgiev]

Not at all. Good hint, thanks for that.Will test it later again.

[VelinGeorgiev]

@waldekmastykarz, couldn't make it work following the instructions.
The following error is present when cmder loads:
C:\cmder/vendor/clink-completions/o365.lua:1011: too many local variables (limit is 200) in main function near '='

Could that be lua language restriction itself?
http://lua-users.org/lists/lua-l/2009-06/msg00412.html

[waldekmastykarz]

Hmm, I've seen it working initially, but maybe it changed when we added more commands. If there is indeed a limit of the number of variables you can have in .lua, then we'd have to restructure the file, to do more things in place instead of in separate variables. Since it's all generated, it shouldn't really matter. Thanks for double checking!