Adds 'spo listitem attachment get' command. Closes #5221

[nanddeepn]

Adds spo listitem attachment get command. Closes #5221

[milanholemans]

Thank you @nanddeepn, we'll try to review it ASAP!

[Jwaegebaert]

Hey @nanddeepn, would you mind updating your PR to utilize ESM? Here's a breakdown of the new changes:

• Make sure that all logging is done asynchronously and awaited

  • cli-microsoft365/src/m365/spo/commands/listitem/listitem-attachment-list.ts

    Line 126 in 515b009

    await logger.log(attachmentFiles.AttachmentFiles);

  • cli-microsoft365/src/m365/spo/commands/listitem/listitem-attachment-list.spec.ts

    Lines 65 to 81 in 515b009

    	beforeEach(() => {
    	log = [];
    	logger = {
    	log: async (msg: string) => {
    	log.push(msg);
    	},
    	logRaw: async (msg: string) => {
    	log.push(msg);
    	},
    	logToStderr: async (msg: string) => {
    	log.push(msg);
    	}
    	};
    	loggerLogSpy = sinon.spy(logger, 'log');
    	loggerLogToStderrSpy = sinon.spy(logger, 'logToStderr');
    	sinon.stub(cli, 'getSettingWithDefaultValue').callsFake(((settingName, defaultValue) => defaultValue));
    	});

• Adjust the way commands are exported
  

  cli-microsoft365/src/m365/spo/commands/listitem/listitem-attachment-list.ts

  Line 140 in 515b009

  export default new SpoListItemAttachmentListCommand();

• Replace all instances of require with import
  

  cli-microsoft365/src/m365/spo/commands/listitem/listitem-attachment-list.spec.ts

  Line 16 in 515b009

  import command from './listitem-attachment-list.js';

• Modify all file imports within the project to have a .js extension

[nanddeepn]

Hi @Jwaegebaert

Can you please guide further on below point in spec.ts?
Replace all instances of require with import

[milanholemans]

Hi @nanddeepn

Because you cannot use require anymore in ESM, you have to refactor const command: Command = require('./listitem-attachment-get') to import command from './listitem-attachment-get.js';. When in doubt, you can always check another command how it's implemented over there.

[nanddeepn]

Thank you @milanholemans

[nanddeepn]

Build failed with error:
Error: '/Users/runner/work/_actions/_temp_8e0dd213-3e1a-4223-a95a-b5681a6bf487/5fa5e269-a8ea-4d88-b889-0796cd17e8eb.tar.gz' contains '0' directories

Any idea, anyone?

[nanddeepn]

Hi @milanholemans
Can you please help to rerun the test cases?

[Jwaegebaert]

Hey @nanddeepn, thanks for the changes. Could you also rebase the latest changes from main into this PR? Right now I'm not able to test this PR locally without a rebase from the main branch.

I've also left a few pointers you can take a look at.

[nanddeepn]

Hi @Jwaegebaert
I had an issue with rebase from main. Raised new PR at #5475
Please review.