Extends 'teams user app remove' command with support for name option. Closes #5447 #5460
Conversation
|
Thanks for your effort @nanddeepn. We'll review it shortly |
waldekmastykarz
added
hacktoberfest-accepted
There was a problem hiding this comment.
Hey @nanddeepn, it seems that you and Reshmee have both submitted a PR to the same file. We're about to merge her PR. Would you be willing to resolve conflicts on yours so that we can pull it in too? I appreciate your help 😊
There was a problem hiding this comment.
Hey @nanddeepn, I'm still getting conflicts when trying to rebase it onto latest main. Could you please rebase with the last main and squash your old commits so that we can clearly merge it without losing any functionality? Thank you!
| } | ||
|
|
||
| if (response.value.length > 1) { | ||
| throw `Multiple Teams apps with name ${args.options.name} found. Please choose one of these ids: ${response.value.map(x => x.id).join(', ')}`; |
There was a problem hiding this comment.
Rather than throwing an error here, we should use Cli.handleMultipleResultsFound() which shows a disambiguation prompt or throws error depending on a user's settings. Sorry I missed it earlier.
|
Hi @waldekmastykarz |
Extends 'teams user app remove' command with support for specifying the
nameoption. Closes #5447