Adds "teams meeting create" command. Closes #1345 #5550
Conversation
|
Great work @mkm17! We'll review ASAP! |
There was a problem hiding this comment.
Hi @mkm17, for your first command this is really well done! I do have some comments, like I always do 😀 could you look at them and get back to me?
By the way: I totally overlooked your remark on hacktoberfest, which is unfortunate. Sorry man! Hope you made it to the required amount of PR's anyway!
|
Hello @martinlingstuyl, thank you for the review. I will make updates later this week. |
mkm17
force-pushed
the
issues/1345_Create_New_Meeting
branch
from
65fd80a to
9cde362
Compare
|
Hi @martinlingstuyl, thank you once again for all the checks. I have made changes to the code and rebased it, so I hope that everything is okay. In case of any issues, let me know, and I will try to correct them promptly. |
|
@martinlingstuyl And just a reminder, before deploying this command, we will need to extend the PnP Office 365 Management Shell app with the 'OnlineMeetings.ReadWrite' permission. https://learn.microsoft.com/en-us/graph/api/application-post-onlinemeetings?view=graph-rest-1.0&tabs=http |
There was a problem hiding this comment.
Hi @mkm17,
One last round of comments. Do check out your use of white lines. We're almost there!
|
Hi @martinlingstuyl thanks again for the review. All requested changes should be included :) |
|
@martinlingstuyl ok I will make the change later today, so you will just have it the merge in on the list. Fingers crossed for your conference presentation! |
|
@martinlingstuyl Ok I have applied the changes. Thanks for the prompt approval! |
|
Merged manually, thank you! 🥳 |
Adds "teams meeting create" command. Closes #1345
Closes #1345
This is my first pull request that introduces a completely new command. I hope that all necessary information is included.
In comparison to the initial concept described in issue #1345, I've made the following changes:
To use this command as the current user, we will need to extend the "PnP Office 365 Management Shell" app with the "OnlineMeetings.ReadWrite" Microsoft Graph delegated permission.
All comments would be more than welcome. :)
I noticed that there is an option to label the PR as Hacktoberfest-related. Since I've joined the event this year, I would appreciate it if you could include it in the initiative.