Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Run "pa app get" as admin. Closes #5518 #5609

Closed
wants to merge 5 commits into from
Closed

Enhancement: Run "pa app get" as admin. Closes #5518 #5609

wants to merge 5 commits into from

Conversation

MartinM85
Copy link
Contributor

Closes #5518

@milanholemans
Copy link
Contributor

Thank you @MartinM85! We'll try to review it ASAP!

@milanholemans milanholemans self-assigned this Oct 31, 2023
milanholemans
milanholemans requested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the super late review @MartinM85. I was hoping to review these PRs sooner but to no avail. Apologies for this.

Could you take a look at the comments I left, please?

docs/docs/cmd/pa/app/app-get.mdx Show resolved Hide resolved
docs/docs/cmd/pa/app/app-get.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/pa/app/app-get.mdx Outdated Show resolved Hide resolved
src/m365/pa/commands/app/app-get.ts Outdated Show resolved Hide resolved
src/m365/pa/commands/app/app-get.ts Outdated Show resolved Hide resolved
src/m365/pa/commands/app/app-get.ts Outdated Show resolved Hide resolved
src/m365/pa/commands/app/app-get.spec.ts Outdated Show resolved Hide resolved
src/m365/pa/commands/app/app-get.spec.ts Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft December 15, 2023 21:53
@MartinM85 MartinM85 marked this pull request as ready for review December 16, 2023 10:56
milanholemans
milanholemans requested changes Dec 23, 2023
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command is working great now. Let's make a few small changes before we merge it.

docs/docs/cmd/pa/app/app-get.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/pa/app/app-get.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/pa/app/app-get.mdx Outdated Show resolved Hide resolved
src/m365/pa/commands/app/app-get.ts Outdated Show resolved Hide resolved
src/m365/pa/commands/app/app-get.spec.ts Outdated Show resolved Hide resolved
src/m365/pa/commands/app/app-get.spec.ts Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft December 23, 2023 23:12
@MartinM85 MartinM85 marked this pull request as ready for review December 26, 2023 17:37
milanholemans
milanholemans approved these changes Jan 1, 2024
View reviewed changes
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work @MartinM85!
Made a few small changes while merging.

src/m365/pa/commands/app/app-get.ts Outdated Show resolved Hide resolved
src/m365/pa/commands/app/app-get.spec.ts Outdated Show resolved Hide resolved
@milanholemans
Copy link
Contributor

Merged manually, thank you for this addition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milanholemans milanholemans Awaiting requested review from milanholemans

Assignees

@milanholemans milanholemans

Labels
pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Run pa app get as admin
2 participants
@MartinM85 @milanholemans