Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend prompting to getGroupIdByDisplayName. Closes #5592 #5612

Closed
wants to merge 2 commits into from
Closed

Extend prompting to getGroupIdByDisplayName. Closes #5592 #5612

wants to merge 2 commits into from

Conversation

nanddeepn
Copy link
Contributor

Extend prompting to getGroupIdByDisplayName. Closes #5592

@milanholemans
Copy link
Contributor

Thank you @nanddeepn, we'll try to review it ASAP!

martinlingstuyl
martinlingstuyl approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @nanddeepn! I'll merge it soon...

@martinlingstuyl martinlingstuyl self-assigned this Oct 31, 2023
@martinlingstuyl martinlingstuyl added hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged labels Oct 31, 2023
@martinlingstuyl
Copy link
Contributor

Merged manually, thank you! 👏🚀

@nanddeepn nanddeepn deleted the issue-5592 branch November 2, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinlingstuyl martinlingstuyl martinlingstuyl approved these changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: extend prompting to getGroupIdByDisplayName util
3 participants
@nanddeepn @milanholemans @martinlingstuyl