-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates why this cli docs #6452
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Some suggestions for improvement.
@waldekmastykarz, @milanholemans ready for another check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few remarks from my side 😊
@milanholemans thanks for your review. I applied most of your comments. Do you wanna take the PR for another spin 🙂? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from a few tiny remarks, nothing more to add. Nice job!
Co-authored-by: Milan Holemans <[email protected]>
Thank you 👍 |
🎯 Aim
Based on our internal discussion the aim is to update the 'Why this CLI' docs page to provide more details and advantages of our product.
📸 Result