Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds spp model apply command. Closes #6119 #6453

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkm17
Copy link
Contributor

@mkm17 mkm17 commented Oct 28, 2024

Adds spp model apply command. Closes #6119

  • I have made some changes to the command compared to the initial specification.

I realized I forgot to add a parameter needed to locate the content site where the model is stored: contentCenterUrl
Let me know if name is ok. We can change it to modelContentSiteUrl or something else.

  • I also modified the viewOption parameter. During testing, I saw that it’s possible to set three different values:NewViewAsDefault, DoNotChangeDefault, TileViewAsDefault

  • The API does not return an error when attempting to apply a model to a custom SharePoint List. However, I’ve added a condition to check if the list is a document library. I hope that’s ok.

  • potentially, when the spp model get command is approved, the getModel function from this command should be exported to the spp.ts file so it can be used by both commands.

@milanholemans
Copy link
Contributor

Thank you for the PR and the additional info @mkm17! We'll get back to you ASAP.

@Adam-it Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 29, 2024

@mkm17 I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

@mkm17 mkm17 force-pushed the issues/6119_spp_model_apply branch 2 times, most recently from c69155f to f366ea7 Compare November 1, 2024 20:31
@milanholemans
Copy link
Contributor

@mkm17, could you resolve the merge conflicts, please?

@milanholemans milanholemans marked this pull request as draft December 8, 2024 18:33
@mkm17 mkm17 force-pushed the issues/6119_spp_model_apply branch from f366ea7 to d7d8e52 Compare December 20, 2024 11:18
@mkm17
Copy link
Contributor Author

mkm17 commented Dec 20, 2024

hi @milanholemans , I apologize for the delay, but I finally found some time to resolve the conflicts here. I have also reviewed the code and made the changes you pointed out in some other spp commands.

@mkm17 mkm17 marked this pull request as ready for review December 20, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New command: m365 spp model apply
3 participants