Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 'm365 spo homesite list'. Closes #6091 #6496

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

reshmee011
Copy link
Contributor

Closes #6492

New Command = Five Files

If your pull request contains the changes for a new command, it should contain five changed files.

For example, a pull request for adding 'teams tab add' command, would include...

  • src/m365/spo/commands.ts
  • src/m365/spo/commands/homesite/homesite-list.ts
  • src/m365/spo/commands/homesite/homesite-list.spec.ts
  • docs/src/config/sidebars.js
  • docs/docs/cmd/spo/homesite/homesite-list.mdx

@milanholemans
Copy link
Contributor

Thank you @reshmee011, we'll have a look at it soon.

Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far @reshmee011! Could you make a few changes before we merge it, please?

src/m365/spo/commands/homesite/homesite-list.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/homesite/homesite-list.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/homesite/homesite-list.ts Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
src/m365/spo/commands/homesite/homesite-list.spec.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/homesite/homesite-list.ts Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
src/m365/spo/commands/homesite/homesite-list.ts Outdated Show resolved Hide resolved
@milanholemans milanholemans self-assigned this Nov 18, 2024
@milanholemans milanholemans marked this pull request as draft November 18, 2024 19:43
@reshmee011 reshmee011 marked this pull request as ready for review November 20, 2024 10:25
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last couple of changes needed before we can merge it.

src/m365/spo/commands/homesite/homesite-list.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/homesite/homesite-list.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/homesite/homesite-list.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/homesite/homesite-list.spec.ts Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft November 20, 2024 22:43
@reshmee011 reshmee011 marked this pull request as ready for review November 20, 2024 23:34
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last couple of changes. We're almost there.

src/m365/spo/commands/homesite/homesite-list.ts Outdated Show resolved Hide resolved
src/m365/spo/commands/homesite/homesite-list.ts Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/spo/homesite/homesite-list.mdx Outdated Show resolved Hide resolved
@milanholemans milanholemans marked this pull request as draft November 23, 2024 23:29
@reshmee011
Copy link
Contributor Author

@milanholemans : Thanks so much for meticulous review:)

@milanholemans
Copy link
Contributor

@reshmee011, is this PR ready for review? If so, can you convert it from draft to ready for review, please?

@reshmee011 reshmee011 marked this pull request as ready for review November 24, 2024 19:22
@reshmee011
Copy link
Contributor Author

@milanholemans :Oops , thought I did convert it to "ready for review". Many thanks.

@milanholemans
Copy link
Contributor

@reshmee011 FYI, I just noticed that the command naming might not be ideal. I'll have to put this PR on hold until #6502 has been approved/declined.

@reshmee011
Copy link
Contributor Author

@milanholemans : no worries, I will wait for the outcome of #6502 before I progress on the outstanding issues related to homesite.

@milanholemans milanholemans marked this pull request as draft November 27, 2024 22:31
@milanholemans
Copy link
Contributor

Hi, @reshmee011 #6502 has been approved. Could you rename the command and move it under the spo tenant umbrella, please? Sorry for the last-minute turnaround.

@reshmee011 reshmee011 marked this pull request as ready for review November 28, 2024 13:37
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from two small oversights, I have nothing more to add!

docs/docs/cmd/spo/tenant/tenant-homesite-list.mdx Outdated Show resolved Hide resolved
docs/src/config/sidebars.ts Outdated Show resolved Hide resolved
@reshmee011
Copy link
Contributor Author

@milanholemans : oops thanks so much for noticing the oversights.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

m365 spo homesite list
2 participants