-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds 'm365 spo homesite list'. Closes #6091 #6496
base: main
Are you sure you want to change the base?
Conversation
Thank you @reshmee011, we'll have a look at it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far @reshmee011! Could you make a few changes before we merge it, please?
Co-authored-by: Milan Holemans <[email protected]>
Co-authored-by: Milan Holemans <[email protected]>
Co-authored-by: Milan Holemans <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last couple of changes needed before we can merge it.
Co-authored-by: Milan Holemans <[email protected]>
Co-authored-by: Milan Holemans <[email protected]>
Co-authored-by: Milan Holemans <[email protected]>
Co-authored-by: Milan Holemans <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last couple of changes. We're almost there.
Co-authored-by: Milan Holemans <[email protected]>
Co-authored-by: Milan Holemans <[email protected]>
Co-authored-by: Milan Holemans <[email protected]>
@milanholemans : Thanks so much for meticulous review:) |
@reshmee011, is this PR ready for review? If so, can you convert it from draft to ready for review, please? |
@milanholemans :Oops , thought I did convert it to "ready for review". Many thanks. |
@reshmee011 FYI, I just noticed that the command naming might not be ideal. I'll have to put this PR on hold until #6502 has been approved/declined. |
@milanholemans : no worries, I will wait for the outcome of #6502 before I progress on the outstanding issues related to homesite. |
Hi, @reshmee011 #6502 has been approved. Could you rename the command and move it under the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from two small oversights, I have nothing more to add!
Co-authored-by: Milan Holemans <[email protected]>
Co-authored-by: Milan Holemans <[email protected]>
@milanholemans : oops thanks so much for noticing the oversights. |
Closes #6492