Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds contributor quote #6508

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Adds contributor quote #6508

wants to merge 1 commit into from

Conversation

Adam-it
Copy link
Member

@Adam-it Adam-it commented Nov 28, 2024

No description provided.

@milanholemans milanholemans self-assigned this Dec 18, 2024
Copy link
Contributor

@milanholemans milanholemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make a couple of improvements before we merge it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's optimize the pictures a bit to display on a website. I like using https://tinypng.com for this. Maybe we should do this with the other images as well. I see one image is a whopping 1MB.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good feed. I am spoiled by company founded Azure storage 😁


<div className='row testimonial'>
<div className='col testimonial-image'>
<img src={require('!!url-loader!../images/testimonials-companies-logo/nanddeep-nachan.png').default} alt='Nanddeep Nachan' />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the documented way of referencing pictures in Docusaurus. This will be important when we introduce versioning in our docs. Let's update the other pictures as well.

Suggested change
<img src={require('!!url-loader!../images/testimonials-companies-logo/nanddeep-nachan.png').default} alt='Nanddeep Nachan' />
<img src={require('@site/docs/images/testimonials-companies-logo/nanddeep-nachan.png').default} alt='Nanddeep Nachan' />

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last time I checked this totally did not work 😜. But I will recheck again

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it myself during reviewing, and it worked for me 😊

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but did you also try it for the .svg file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I haven't. I would expect it to work the same way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that is also what I expected but I already did that attempt and wrote it here
#6450 (comment)
and at that time it worked for .png files but not for .svg file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to look into it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adam-it, where is the SVG file actually? I don't see one on the testimonials page.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aa sorry, There was one from Voitanos but I see this was updated by AC 🙂. Problem solved then

<p>Profile: https://www.linkedin.com/in/nanddeepnachan/</p>
</div>
<div className='col testimonial-quote'>
<p>The CLI for Microsoft 365 is an incredible tool that empowers customers to automate and streamline their tasks across Microsoft 365 services with ease and flexibility. Its cross-platform capabilities make it a versatile choice for managing SharePoint, Teams, and more, reducing manual efforts and enhancing productivity. <br /> As an active contributor to this project, I am proud to be part of a community driving innovation and simplifying Microsoft 365 management for users worldwide.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight enhancements

Suggested change
<p>The CLI for Microsoft 365 is an incredible tool that empowers customers to automate and streamline their tasks across Microsoft 365 services with ease and flexibility. Its cross-platform capabilities make it a versatile choice for managing SharePoint, Teams, and more, reducing manual efforts and enhancing productivity. <br /> As an active contributor to this project, I am proud to be part of a community driving innovation and simplifying Microsoft 365 management for users worldwide.</p>
<p>The CLI for Microsoft 365 is an incredible tool that empowers users to automate and streamline their tasks across Microsoft 365 services with ease and flexibility. Its cross-platform capabilities make it a versatile choice for managing SharePoint, Teams, and more, reducing manual effort and boosting productivity. <br /> As an active contributor to this project, I am proud to be part of a community that drives innovation and simplifies Microsoft 365 management for users worldwide.</p>

@milanholemans milanholemans marked this pull request as draft December 18, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants