fix: include the protocol when creating HttpIncoming #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We perhaps designed this with the intention of a ClientRequest which has the protocol property, but we get an HttpIncomingMessage which doesn't have the protocol. |
|
This is likely a regression we didn't catch in the interaction between In |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 25, 2024
## [3.0.11](v3.0.10...v3.0.11) (2024-09-25) ### Bug Fixes * include the protocol when creating HttpIncoming ([#279](#279)) ([efee917](efee917))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that podlets using mount origin from the context didn't get the correct protocol in in HTTPS origins.
https://github.com/podium-lib/context/blob/main/lib/get-mount-origin.js
Turns out the raw request we pass down in the Fastify plugin doesn't include the protocol.