refactor insights url generator and add annotation support

lib/ex_twilio/config.ex

@@ -71,7 +71,7 @@ defmodule ExTwilio.Config do
 
   def video_url, do: "https://video.twilio.com/v1"
 
-  def voice_insights_url, do: "https://insights.twilio.com/v1/Voice"
+  def voice_insights_url, do: "https://insights.twilio.com/v1"
 
   def preview_url, do: "https://preview.twilio.com/marketplace"
 

lib/ex_twilio/resources/insights/annotation.ex

@@ -0,0 +1,23 @@
+defmodule ExTwilio.Insights.Annotation do
+  @moduledoc """
+  Represents Voice Insights Annotation Resource.
+
+  - [Twilio docs](https://www.twilio.com/docs/voice/voice-insights/api/call/call-annotation-resource)
+  """
+
+  defstruct [
+    :call_sid,
+    :answered_by,
+    :connectivity_issue,
+    :quality_issues,
+    :spam,
+    :call_score,
+    :comment,
+    :incident
+  ]
+
+  use ExTwilio.Resource, import: [:find, :create]
+
+  def parents, do: [%ExTwilio.Parent{module: ExTwilio.Insights.Voice, key: :call_sid}]
+  def resource_name, do: "Annotation"
+end

lib/ex_twilio/resources/insights/voice/settings.ex → lib/ex_twilio/resources/insights/settings.ex

@@ -1,4 +1,4 @@
-defmodule ExTwilio.Insights.Voice.Settings do
+defmodule ExTwilio.Insights.Settings do
   @moduledoc """
   Represents Voice Insights Settings Resource.
 
@@ -14,4 +14,6 @@ defmodule ExTwilio.Insights.Voice.Settings do
   ]
 
   use ExTwilio.Resource, import: [:find, :create]
+
+  def resource_name, do: "Voice/Settings"
 end

lib/ex_twilio/resources/insights/voice.ex

@@ -0,0 +1,8 @@
+defmodule ExTwilio.Insights.Voice do
+  @moduledoc """
+  This is module only exists to add "Voice" to url before each of the Insights urls
+  the Insights urls seem to break the pattern of the rest of the Twilio base urls
+  """
+
+  def resource_name, do: "Voice"
+end

lib/ex_twilio/url_generator.ex

@@ -89,7 +89,7 @@ defmodule ExTwilio.UrlGenerator do
     {url, options}
   end
 
-  defp construct_url(["ExTwilio", "Insights", "Voice" | _], module, id, options) do
+  defp construct_url(["ExTwilio", "Insights" | _], module, id, options) do
     url = add_segments(Config.voice_insights_url(), module, id, options)
     {url, options}
   end