src/donations: Fix wrong unique donors count #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when we count unique donors we group them by billing_name, which gives us the total number of unique donors. The number of total donors is then added, to the total amount of donations made by the first user in the returned query. This results in overestimating the actually count of unique donors. Changed the query to plain SQL, as prisma doesn't yet support counting by distinct properties, and counting is relatively faster to process, than grouping or searching Changed the query to count by distinct billing_email property, rather than billing_name, as email is the "more unique" property of the two.
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
slavcho
approved these changes
Dec 12, 2023
|
|
||
| // get count of the donations with billingName == null | ||
| const anonymousDonations = donorsCount[0]._count._all | ||
| const donorsCount = await this.prisma.$queryRaw<{ |
There was a problem hiding this comment.
queryRaw - this is usefull to learn :)
github-actions
bot
removed
the
run tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when we count unique donors we group them by billing_name, which gives us the total number of unique donors. The number of total donors is then added, to the total amount of donations made by the first user in the returned query. This results in overestimating the actual count of unique donors.
Changed the query to plain SQL, as prisma doesn't yet support counting by distinct properties, and counting is relatively faster to process, than grouping or searching
Changed the query to count by distinct billing_email property, rather than billing_name, as email is the "more unique" property of the two.