src/donations: Don't update updatedAt field on iris re-import #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since campaign donations are ordered by updatedAt field on the front-end, this causes to bank donations to reappear at top every hour. Temporary solution until we figure out, the reason updating of imported donation is needed.
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
slavcho
reviewed
Jan 23, 2024
| @@ -583,7 +583,7 @@ export class DonationsService { | |||
| //Donation exists, so updating with incoming donation without increasing vault amounts | |||
| await this.prisma.donation.update({ | |||
| where: { extPaymentIntentId: donationDto.extPaymentIntentId }, | |||
| data: donationDto, | |||
| data: { ...donationDto, updatedAt: existingDonation.updatedAt }, | |||
There was a problem hiding this comment.
Just for my curiosity...
if the donation already exists - why do we even update it?
There was a problem hiding this comment.
I have no idea either thus decided to keep it for now, just in case of specific edge-case I can't think of.
@BogoCvetkov is it safe to remove this update query?
slavcho
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since campaign donations are ordered by updatedAt field on the front-end, this causes to bank donations to reappear at top every hour.
This is temporary solution until the reason for updating existing donation record is figured out.