[1/2]: Overhaul of donations module #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Payment table will save the information regarding the payment - Donation table will save information regarding the donation(e.g. campaign, wish etc..)
In future situations, we might need to decrement many vaults at once as well,(e.g. payment refund etc..) - Added some unit tests to cover vaults updates -Did some refactoring on commonly used types, as well as test mocks
As the name of the model is used as a type, the acceptednaming convention is to name that type in singular way
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
github-actions
bot
removed
the
run tests
igoychev
reviewed
Mar 4, 2024
| ) RETURNING id | ||
| ) | ||
|
|
||
| SELECT * INTO payment_result FROM payment; |
There was a problem hiding this comment.
payment_results looks unused, but seems not a problem
There was a problem hiding this comment.
It's used in the statement below, when inserting the id of the inserted payment row, into donations table.
| @@ -23,4 +28,49 @@ describe('VaultService', () => { | |||
| it('should be defined', () => { | |||
| expect(service).toBeDefined() | |||
| }) | |||
|
|
|||
| it('decrementManyVaults should throw an error if one vaults returns negative amount', async () => { | |||
Fixes TS related errors
…when simulating IRIS transactions
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
igoychev
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Currently two major features are queued:
It was discussed among the PM, and dev team, that our current structure is not fit for situations, where funds from one payment can be allocated to more than one campaign.
For this reason a new structure was proposed, which makes the relation between a payment and campaign vaults M:N, with donations table being the "middle-man", connection a payment to campaign vault. Figure below"
To make this happen, the current donations structure, was split into two tables payments and donations, with relation between those tables being 1:N(one payment, can be linked to one or more donations)
Testing
Steps to test
New endpoints
/donations/payments - Get information just for the made payments