Update Subscription modal translations #1860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ani-kalpachka
commented
Jun 21, 2024
ani-kalpachka
commented
- Update Subscription modal translations on the pages that they were missing.
- Update punctuation on validation.json.
sashko9807
requested changes
Jun 22, 2024
There was a problem hiding this comment.
GeneralSubscriptionModal is accessible on every page through the footer, so any translations to it must be in the common namespace.
Please put the untranslated modal texts inside the common.json, within the notifications object, and make the necessary changes to the AcceptNewsletterField.tsx and GeneralSubscribeModal.tsx components.
|
@sashko9807 I agree. Thanks for the review. I will close this PR and create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.