Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/1915-Profile-Birthdate-Validation-Message #1952

Conversation

velnachev
Copy link
Contributor

Fixed no UI feedback on FormDatePicker when maxDate validation constraint is present

  • Added maxDate optional prop to FormDatePicker component to be used in error state feedback
  • maxDate validation applied to the calendar, so invalid dates cannot be selected from it, limiting issue to manual inputs
  • Added error color from figma designs to theme color palette
  • Left maxDate prop to be required when displaying the input error state to prevent issues in other places where component is used

Closes #1915

Screenshots:

Before After
image image

Testing

Steps to test

  1. Open https://podkrepi.bg/en/profile/personal-information
  2. Click edit on Birthday
  3. Add date 03/10/2017 and observe error state of the input field
  4. Click button
  5. Add date that is 18+ years ago and observe error state of the input field
  6. Click button

Affected urls

Environment

New environment variables:

  • NEW_ENV_VAR: env var details

New or updated dependencies:

Dependency name Previous version Updated version Details
dependency/name v1.0.0 v2.0.0

Copy link

github-actions bot commented Oct 7, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

@ani-kalpachka ani-kalpachka added the run tests Allows running the tests workflows for forked repos label Oct 7, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Oct 7, 2024
@ani-kalpachka ani-kalpachka added the run tests Allows running the tests workflows for forked repos label Oct 7, 2024
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Oct 7, 2024
@ani-kalpachka ani-kalpachka merged commit 36262bb into podkrepi-bg:master Oct 7, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Try to change Birthdate in personal-information to 03/10/2017 not work
2 participants